RFR: 8241982: Make TestSearchScript.java run with GraalJS

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Apr 14 16:48:52 UTC 2020


Looks good to me.

As a minor enhancement, either now or later, note that jtreg recognizes 
the use of an exception named 'jtreg.SkippedException` such as the one 
declared here:

test/lib/jtreg/SkippedException.java

This is used to help indicate when a test was skipped for any reason.

-- Jon

On 4/2/20 7:57 AM, Hannes Wallnoefer wrote:
> Please review:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8241982
> Webrev: http://cr.openjdk.java.net/~hannesw/8241982/webrev.00/
>
> This makes TestSearchScript.java run with GraalJS in addition to 
> Nashorn, and potentially with any other compatible JSR-223 JavaScript 
> engine. I have tested it with both Nashorn and GraalJS. The test is 
> skipped if no JavaScript engine is available.
>
> Thanks,
> Hannes


More information about the javadoc-dev mailing list