[jdk16] RFR: 8223607: --override-methods=summary ignores some signature changes

Hannes Wallnöfer hannesw at openjdk.java.net
Fri Dec 18 14:31:38 UTC 2020


Jon, 

I created a new pull request for this on the jdk16 repository because the original one was created on the mainline jdk repo. The first commit in this PR is identical to the one you already reviewed in the old PR. The second commit adds checks and tests for changes from non-final to final and changes in abstractness of overriding methods. Thus the full list of conditions under which a simple overriding method is included in the details section of the overriding class is now:


    - method access changes from protected to public
    - method is overridden as final
    - method overridden with different abstractness
    - any change in thrown exceptions
    - change in documented annotations anywhere in the method signature

-------------

Commit messages:
 - Include conditions listed in JDK-8258429
 - JDK-8223607: --override-methods=summary ignores some signature changes

Changes: https://git.openjdk.java.net/jdk16/pull/52/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=52&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8223607
  Stats: 472 lines in 7 files changed: 443 ins; 15 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/52.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/52/head:pull/52

PR: https://git.openjdk.java.net/jdk16/pull/52


More information about the javadoc-dev mailing list