[jdk16] RFR: 8223607: --override-methods=summary ignores some signature changes [v2]

Jonathan Gibbons jjg at openjdk.java.net
Fri Dec 18 15:36:36 UTC 2020


On Fri, 18 Dec 2020 14:40:44 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Jon, 
>> 
>> I created a new pull request for this on the jdk16 repository because the original one was created on the mainline jdk repo. The first commit in this PR is identical to the one you already reviewed in the old PR. The second commit adds checks and tests for changes from non-final to final and changes in abstractness of overriding methods. Thus the full list of conditions under which a simple overriding method is included in the details section of the overriding class is now:
>> 
>> 
>>     - method access changes from protected to public
>>     - method is overridden as final
>>     - method overridden with different abstractness
>>     - any change in thrown exceptions
>>     - change in documented annotations anywhere in the method signature
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor fix in test comment

Nice.

Marked as reviewed by jjg (Reviewer).

Marked as reviewed by jjg (Reviewer).

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/52


More information about the javadoc-dev mailing list