RFR: JDK-8238503 Remove unused field and accessor for docLocale from ToolOptions

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Feb 6 15:49:56 UTC 2020


Hannes,

Good catch.  The file manager is used in preprocess, to set up the 
doclet, but you
are correct that it is not used via the parameter.

I've already pushed the basic work, so I'll file a separate issue to 
clean this up.

-- Jon

On 2/6/20 7:30 AM, Hannes Wallnöfer wrote:
> Looks good.
>
> The JavaFileManager argument in Start.preprocess is never used and could be removed.
>
> Hannes
>
>
>> Am 05.02.2020 um 00:54 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>:
>>
>> Please review a cleanup to remove some dead code and improve comments
>> for the tool options that are implemented in Start.preprocess.
>>
>> No intentional change in functionality.
>>
>> -- Jon
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8238503
>> Webrev: http://cr.openjdk.java.net/~jjg/8238503/webrev/index.html
>>


More information about the javadoc-dev mailing list