RFR: JDK-8200363 Add javadoc command line setting to fail on warnings

[Jonathan Gibbons]

Hannes,

Thanks for catching the references to Xwerror in comments. Fixed, new 
webrev uploaded.  I will leave the localized resource files to be 
updated by the L10N team and their tools.

No other changes in the webrev.

-- Jon

Webrev: http://cr.openjdk.java.net/~jjg/8200363/webrev.01/


On 01/29/2020 07:18 AM, Hannes Wallnöfer wrote:
> Hi Jon,
>
> This looks good. I just found a few minor things to clean up:
>
> - in ToolOptions.java the definitions of the rejectWarnings field and method both have comments mentioning the old -Xwerror option. These should be updated to refer to the new -Werror option
>
> - main.opt.Xold.desc property should probably also be removed from javadoc_ja.properties and javadoc-zh_CN.properties. It is also documented in share/man/javadoc.1
>
> Hannes
>
>
>> Am 28.01.2020 um 23:46 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>:
>>
>> Please review a simple change to (finally) implement the long-overdue -Werror option.
>>
>> The existing undocumented -Xwerror option is repurposed and renamed, and its behavior modified to match the javac -Werror option.  The old name is retained as a alias "for a while" but since it is an undocumented option it may be removed at any time, and perhaps in the next release after this change (i.e. 16.)
>>
>> In the resource file, an unused property is removed, and an error (mismatched braces) is fixed in another.
>>
>> -- Jon
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8200460
>> Webrev: http://cr.openjdk.java.net/~jjg/8200363/webrev.00/
>>