RFR: [15] JDK-8245696 javadoc crashes when a doc-files directory contains a '#' file
Jonathan Gibbons
jonathan.gibbons at oracle.com
Wed Jun 17 14:54:38 UTC 2020
Here, for the record, is the correct webrev, posted at the correct location:
http://cr.openjdk.java.net/~jjg/8245696/webrev.00/
-- Jon
On 6/17/20 7:27 AM, Jonathan Gibbons wrote:
> Thanks, I'll fix the bad bugid.
>
> Sorry for the confusion.
>
> -- Jon
>
> On 6/17/20 6:21 AM, Hannes Wallnoefer wrote:
>> Jon,
>>
>> I just noticed that in the mix-up of this bug with 8243113 the wrong
>> bug id ended up being added to the @bug tag in TestDocFiles.java.
>>
>> Hannes
>>
>>> Am 17.06.2020 um 15:13 schrieb Hannes Wallnoefer
>>> <hannes.wallnoefer at oracle.com>:
>>>
>>> Hi Jon,
>>>
>>> Looks good!
>>>
>>> Hannes
>>>
>>>> Am 17.06.2020 um 06:48 schrieb Jonathan Gibbons
>>>> <jonathan.gibbons at oracle.com>:
>>>>
>>>> Please review a simple fix to prevent javadoc crashing when it
>>>> encounters a badly-named
>>>> file in a doc-files subdirectory.
>>>>
>>>> The problem is caused by checks in JavaFileManager causing
>>>> IllegalArgumentException
>>>> to be thrown. Rather than catch those exceptions, the files in the
>>>> doc-files source
>>>> directory are checked with similar checks, so that a warning can be
>>>> given and the
>>>> files ignored.
>>>>
>>>> -- Jon
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245696
>>>> Webrev: http://cr.openjdk.java.net/~jjg/8243113/webrev.00/
>>>>
More information about the javadoc-dev
mailing list