RFR: [15]JDK-8247955,doclint: don't complain about summary/caption when role=presentation

Pavel Rappo pavel.rappo at oracle.com
Mon Jun 22 13:17:17 UTC 2020


Jon,

1. Should we refine this wording to reflect the change?

    dc.no.summary.or.caption.for.table=no summary or caption for table

2. Does it make sense to test all the possibilities? Currently our tests cover 50% of that space.

tested|caption|summary|role
----------------------------
          +       +     +
          +       +     -
          +       -     +
   +      +       -     -
          -       +     +
   +      -       +     -
   +      -       -     +
   +      -       -     -

***

I was surprised by

    Objects.equals(v, "presentation")

I guess, I was expecting a more familiar

    "presentation".equals(v).

But there's nothing wrong with using Objects.equals.

-Pavel

> On 20 Jun 2020, at 03:40, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Please review a small adjustment for doclint: to suppress the check for
> a table having a caption when the table has `role=presentation`.
> 
> There's an existing AccessibilityTest.java, but that is still focussed on
> HTML 4, which does not support role=presentation. So, a new test
> is added (for now) that is focussed on this test case, in HTML 5.
> When we drop support for HTML 4, we should merge the two files.
> 
> -- Jon
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8247955
> Webrev: http://cr.openjdk.java.net/~jjg/8247955/webrev.00/
> 



More information about the javadoc-dev mailing list