RFR: JDK-8240476: SystemPropertiesWriter does not conform to standard page layout

Pavel Rappo pavel.rappo at oracle.com
Thu Mar 19 12:18:28 UTC 2020


These lines are commented out:

  65 //    /**
  66 //     * The HTML tree for main tag.
  67 //     */
  68 //    private final HtmlTree mainTree = HtmlTree.MAIN();
  69 

Do you intend to leave them like this?
Otherwise, looks good to me. Thanks.

-Pavel

> On 19 Mar 2020, at 00:43, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Please review a simple localized fix to construct the System Properties page
> using the recently-new standard flex-box layout.
> 
> For reference, the modified code was based on equivalent code in SingleIndexWriter.generateIndexFile.
> 
> The existing test for the page is extended with additional checks for the new behavior.
> 
> -- Jon
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8240476
> Webrev: http://cr.openjdk.java.net/~jjg/8240476/webrev.00/index.html
> 



More information about the javadoc-dev mailing list