RFR: JDK-8245062 HtmlStyle: group and document members for nav, header, summary, details

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed May 27 23:42:37 UTC 2020


Hannes,

Thanks for the feedback. I've addressed all your concerns.

In writing a demo module to investigate your initial comment, I 
uncovered two bugs (corrupt index.html file, and missing output). I'll 
file separate issues.

-- Jon

On 5/26/20 5:46 AM, Hannes Wallnoefer wrote:
> Hi Jon,
>
> Line 198: "Note: the "Summary" information on a module declaration page would be better characterized as "Details" information."
> Not sure I understand the rationale behind this sentence. It seems the module page is still a summary list that links to details, although the details are on separate pages (type and package pages).
>
> Line 289: I think „Constants Summary“ page should be „Constant Values“ or „Constant Field Values“ page.
>
> The „System Properties Summary“ in line 308 has a typo („Porperties“) and is just called „System Properties“ page.
>
> Otherwise the changes and generated docs look good.
>
> Hannes
>
>
>> Am 16.05.2020 um 02:42 schrieb Jonathan Gibbons <jonathan.gibbons at oracle.com>:
>>
>> Please review a mostly doc-only update to document a bunch more of the members of HtmlStyle.
>> The only code-change aspect is the members that are documented are rearranged into groups.
>> No members are added or removed, or changed in how they are used.
>>
>> As before, some irregularities in the naming become apparent as part of this process.
>> These irregularities will be handled later.
>>
>> Note to self: there's a typo in the first change "fromthe". I'll fix that.
>>
>> -- Jon
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245062
>> Webrev: http://cr.openjdk.java.net/~jjg/8245062/webrev.00/
>>


More information about the javadoc-dev mailing list