RFR [15] 8236823: Ensure that API documentation uses minified libraries

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri May 29 14:47:55 UTC 2020


On 5/28/20 7:08 AM, Pavel Rappo wrote:
> 1. I don't understand why JDK-8222548 renamed "jquery.js" to "jquery-3.4.1.js". Unless necessary, things like this introduce unneeded churn to the codebase. It's much cleaner to change just the contents of a file rather than both the contents and the name as that name might be used in the codebase. So, I'm thinking of renaming jquery-x.y.z.v.js back to just jquery.v.js.

JDK-8222548 was just continuing the pattern.  Not an excuse; just an 
explanation.

--- 
a/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java 
Thu May 16 10:52:36 2019 +0200
+++ 
b/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java 
Thu May 16 16:40:48 2019 +0530
@@ -199,8 +199,7 @@

private void copyJqueryFiles() throws DocletException {
List<String> files = Arrays.asList(
- "jquery-3.3.1.js",
- "jquery-migrate-3.0.1.js",
+ "jquery-3.4.1.js",
"jquery-ui.js",
"jquery-ui.css",
"jquery-ui.min.js",


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/javadoc-dev/attachments/20200529/f051250d/attachment.htm>


More information about the javadoc-dev mailing list