RFR: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements [v3]
Jonathan Gibbons
jjg at openjdk.java.net
Wed Oct 7 00:13:20 UTC 2020
On Fri, 25 Sep 2020 17:50:39 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains seven commits:
>> - Merge master
>> - Address issues raised in code review:
>> - remove unused styles and method
>> - rename alternating table row styles
>> - move id attribute for tabs
>> - add line breaks in test text blocks to make them easier to read and maintain
>> - Fix trailing whitespace
>> - Clean up comments and styles
>> - Restore table spacing
>> - Adapt tests to grid summaries
>> - Use CSS Grid Layout for javadoc summaries
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css line 440:
>
>> 438: .summary-table > div {
>> 439: text-align:left;
>> 440: padding: 8px 3px 3px 7px;
>
> General comment: should we be using some font-related unit such as `em` `ex` instead of absolute units like `px` ?
Comment?
-------------
PR: https://git.openjdk.java.net/jdk/pull/253
More information about the javadoc-dev
mailing list