RFR: JDK-8254721: Improve support for conditionally generated files

[Jonathan Gibbons]

On Mon, 19 Oct 2020 15:49:05 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> The overall pages is very dynamic and depends on a lot of factors, such as the input files and the command-line
>> options. Some of the summary files depend on the content of the classes being documented, such as:
>> * any constant values declared in the files
>> * any deprecated elements
>> * any serializable classes
>> * any classes whose description references system properties
>> 
>> This change is a step towards handling these files in a uniform manner.
>> 
>> There is a new test to test the consistency of the new behavior..
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java line 267:
> 
>> 265:     public static void generate(HtmlConfiguration configuration) throws DocFileIOException {
>> 266:         DeprecatedAPIListBuilder deprAPI = configuration.deprecatedAPIListBuilder;
>> 267:         if (deprAPI != null && !deprAPI.isEmpty()) {
> 
> Just a note regarding consistency: everywhere else you are using
> `configuration.conditionalPages.contains(HtmlConfiguration.PageKind.DEPRECATED)` for this check.

Yes, thanks; noted; I guess this is a hangover from before I added the PageKind.

-------------

PR: https://git.openjdk.java.net/jdk/pull/674