RFR: JDK-8253733: Cleanup internal taglet API
Pavel Rappo
prappo at openjdk.java.net
Wed Sep 30 11:19:10 UTC 2020
On Tue, 29 Sep 2020 16:42:09 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> This is a general cleanup of various classes related to the handling of tags and taglets in the standard doclet.
>
> The initial motivation was to clean up static methods on `TagletWriter` that took a `TagletWriter` as a parameter.
> These methods are converted into instance methods, and the call sites simplified as well.
> Another area of cleanup is to make clear which methods are used for inline tags and which are used for block tags.
>
> Some dead code is removed, and the doc comments are generally cleaned up as well. More details are given in the JBS
> issue.
Changes requested by prappo (Reviewer).
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SimpleTaglet.java line 182:
> 180: @Override
> 181: public Content getInlineTagOutput(Element element, DocTree tag, TagletWriter writer) {
> 182: return null;
I know that the corresponding `simpleTagOutput` method was deleted in this patch, but could you explain why this is a
valid substitution?
-------------
PR: https://git.openjdk.java.net/jdk/pull/406
More information about the javadoc-dev
mailing list