RFR: 8261168: Convert javadoc tool to use Stream.toList() [v3]

Ian Graves igraves at openjdk.java.net
Thu Apr 22 17:06:40 UTC 2021


On Thu, 22 Apr 2021 09:16:40 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tweaking some comments and list/stream concatenation
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java line 461:
> 
>> 459:                 .collect(Collectors.toList());
>> 460: 
>> 461:         // Prefix local results first
> 
> 1. Could you incorporate this comment instead of deleting it?
> 2. Consider refactoring L502:L516 in a similar fashion, i.e. `a.addAll(0, b)` -> `Stream.concat(b, a)`.

Done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3612


More information about the javadoc-dev mailing list