RFR: 8265684: implement Sealed Classes as a standard feature in Java, javadoc changes [v5]

Jonathan Gibbons jjg at openjdk.java.net
Fri Apr 30 03:37:51 UTC 2021


On Fri, 23 Apr 2021 03:28:09 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Please review the javadoc related changes to make sealed classes a final feature in Java. The patch is mostly removing preview features related code that is not necessary anymore in javadoc.
>> 
>> TIA
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing indentation issues

Depending who goes first, there may be a merge conflict with removing some of
the `@SuppressWarnings` annotations.

test/langtools/jdk/javadoc/doclet/testSealedTypes/TestSealedTypes.java line 251:

> 249:                 "package p; public final  class B extends A { }",
> 250:                 "package p; public final  class C extends A { }",
> 251:                 "package p; sealed class D extends A permits D1, D2 { }",

(minor)   don't delete the spaces; the class names were previously vertically aligned

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3613


More information about the javadoc-dev mailing list