RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Pavel Rappo prappo at openjdk.java.net
Fri Aug 20 10:51:23 UTC 2021


On Fri, 20 Aug 2021 10:12:11 GMT, Masanori Yano <myano at openjdk.org> wrote:

> Could you please review the 8248001 bug fixes?
> 
> The problem is that javadoc generates invalid HTML pages whose ftp:// links are broken. The fix changes not to use protocol names directly, but to use regular expression.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1703:

> 1701:             return text;
> 1702:         }
> 1703:         if (text.matches("^[^:/?#]+:.+$")) {

Why not use `java.net.URI` API to determine if the link contains a scheme?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5198


More information about the javadoc-dev mailing list