RFR: JDK-8271258: @param with non-ascii variable names produces incorrect results

[Jonathan Gibbons]

On Thu, 19 Aug 2021 09:35:11 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Please review a simple change to fix the use of non-ASCII characters in @param names.
>> 
>> The underlying problem was accidentally relying on `DocTree.toString()` for an `IdentifierTree` in `CommentHelper`.  The fix is simply to get the underlying `Name` and call `toString` on that.
>> 
>> There is some loosely related cleanup in `ParamTaglet`. I did see if it was possible to avoid excessive use of `String` in this part of the code, but that quickly became a rat-hole.
>> 
>> The existing related test is updated to include this new case, of a Chinese identifier occurring in various places, similar to the test case in the original bug.
>
> test/langtools/jdk/javadoc/doclet/testUnicode/TestUnicode.java line 64:
> 
>> 62:         checkOutput("Code.html", true,
>> 63:                 """
>> 64:                         """);
> 
> Is don't think this is supposed to be an empty string, is it?

Oops, will investigate what happened in my repo.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5168