RFR: JDK-8271258: @param with non-ascii variable names produces incorrect results [v2]

[Hannes Wallnöfer]

On Mon, 23 Aug 2021 18:07:00 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a simple change to fix the use of non-ASCII characters in @param names.
>> 
>> The underlying problem was accidentally relying on `DocTree.toString()` for an `IdentifierTree` in `CommentHelper`.  The fix is simply to get the underlying `Name` and call `toString` on that.
>> 
>> There is some loosely related cleanup in `ParamTaglet`. I did see if it was possible to avoid excessive use of `String` in this part of the code, but that quickly became a rat-hole.
>> 
>> The existing related test is updated to include this new case, of a Chinese identifier occurring in various places, similar to the test case in the original bug.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   repair broken test.

Looks good now!

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5168