RFR: JDK-8261203: Incorrectly escaped javadoc html with type annotations

Hannes Wallnöfer hannesw at openjdk.java.net
Thu Feb 25 11:17:48 UTC 2021


On Thu, 25 Feb 2021 00:02:51 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple change to exclude type annotations from primitive types in the id generated for a method signature.
> 
> There's a latent secondary issue, not addressed here, that quotes (`"`) in an attribute value are not escaped correctly. That could be fixed, separately, at the cost of checking every generated attribute value. For now, at least for ids, we can avoid this issue by constraining the set of attribute values, which for ids, is now easier, in the recently-new `HtmlIds` class.

Looks good!

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2719


More information about the javadoc-dev mailing list