RFR: JDK-8259283: use new HtmlId and HtmlIds classes [v3]

[Jonathan Gibbons]

On Wed, 13 Jan 2021 10:53:30 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tidy up merge
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java line 234:
> 
>> 232:      * @return a content tree for the link
>> 233:      */
>> 234:     public Content createExternalLink(DocLink link, Content label) {
> 
> The `createLink(DocLink, Content, boolan)` method above (line #221) that is replaced by this new method is not used anymore (and within it, the boolean parameter is not used).

Ah, good catch!  Will fix.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java line 301:
> 
>> 299:             rowStyle = stripedStyles.get(rowIndex % 2);
>> 300:         }
>> 301:         Set<String> tabClasses = new HashSet<>(); // !! would be better as a List
> 
> I assume no bug has been filed for this?

Not yet. I have a list of a number of minor cleanups to do.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIndexBuilder.java line 75:
> 
>> 73:         super(configuration, configuration.getOptions().noDeprecated());
>> 74:         this.configuration = configuration;
>> 75:         links = new Links(DocPath.empty);
> 
> It looks like `links` isn't used anywhere else in `HtmlIndexBuilder` and can be removed.

OK, will check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1951