[jdk17] RFR: JDK-8259499: Handling type arguments from outer classes for inner class in javadoc [v2]
Hannes Wallnöfer
hannesw at openjdk.java.net
Mon Jul 12 16:43:34 UTC 2021
On Fri, 9 Jul 2021 02:42:38 GMT, liach <github.com+7806504+liach at openjdk.org> wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkInfo.java line 132:
>>
>>> 130: // from the documentation of an inner class, so rendering it as separate link would
>>> 131: // add little benefit but add considerable noise, while type arguments may not
>>> 132: // otherwise be reachable from the documentation of the inner class.
>>
>> Do you render the _enclosing types_ as separate links, or just the _type arguments of enclosing types_?
>>
>> Even if the enclosing type has type arguments, your argument about the noise from linking the name of the enclosing type is still valid.
>
> Currently the first. But if someone clicks the class label in front of type arguments, thinking it would lead to the class that defines the type parameters (as in many IDEs) and instead goes to the innermost class, it'd be quite confusing too.
Yes, it is either all type components as separate links, or none.
-------------
PR: https://git.openjdk.java.net/jdk17/pull/195
More information about the javadoc-dev
mailing list