RFR: 8270836: Foolproof JavadocTester.checkOutput [v3]

Jonathan Gibbons jjg at openjdk.java.net
Fri Jul 16 17:44:55 UTC 2021


On Fri, 16 Jul 2021 16:10:30 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> When searching output for multiple strings it is easy to misexpress your intent, which could make a failing test pass. Such cases can be caught and reported to the programmer.
>> 
>> For example, for this search to succeed it is sufficient for the output to consist only of the `"error: bad"` string:
>> 
>> 
>> checkOutput(..., "error:", "error: bad", ...)
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address feedback

Marked as reviewed by jjg (Reviewer).

test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 564:

> 562:         Arrays.sort(copy);
> 563:         for (int i = 0; i < copy.length - 1; i++) {
> 564:             if (copy[i + 1].startsWith(copy[i]))

��

-------------

PR: https://git.openjdk.java.net/jdk/pull/4811


More information about the javadoc-dev mailing list