RFR: 8270836: Foolproof JavadocTester.checkOutput [v4]

[Pavel Rappo]

On Thu, 22 Jul 2021 09:23:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> When searching output for multiple strings it is easy to misexpress your intent, which could make a failing test pass. Such cases can be caught and reported to the programmer.
>> 
>> For example, for this search to succeed it is sufficient for the output to consist only of the `"error: bad"` string:
>> 
>> 
>> checkOutput(..., "error:", "error: bad", ...)
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address feedback and more
>   
>   Search for confusing strings using indexOf. Detect confusing strings across multiple calls to checkOutput. Remove the test which would otherwise have to become very complicated.

I've pushed one more commit, ee5c92f, to bring this PR to a safepoint and suspend the work. This is because of the unexpectedly big number of test issues that this PR has uncovered. I think that before resuming the work on this PR, we need to examine and fix each of the affected tests.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4811