RFR: 8266666: Implementation for snippets [v5]

Hannes Wallnöfer hannesw at openjdk.java.net
Thu Jul 29 16:06:35 UTC 2021


On Wed, 28 Jul 2021 14:40:55 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> This PR implements JEP 413 "Code Snippets in Java API Documentation", which hasn't been yet proposed to target JDK 18. The PR starts as a squashed merge of the https://github.com/openjdk/jdk-sandbox/tree/jdk.javadoc/snippets branch.
>
> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Change AnnotatedText<T> to StyledText
>    
>    Renames the class, removes its generic parameter, and changes the related terminology from "annotate" to "style".
>  - Restructure ...toolkit.taglets.snippet.** packages
>    
>    This commit moves the contents of the jdk.javadoc.internal.doclets.toolkit.taglets.snippet.{action,parser,text} packages into the jdk.javadoc.internal.doclets.toolkit.taglets.snippet package.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css line 884:

> 882: 
> 883: pre.snippet .highlighted {
> 884:     background-color: sandybrown;

Here I think the color clashes a bit with the very similar orange we use for table headers/tabs. I'm not really sure about this one, but maybe a "watered down" orange with a similar tone but less saturation could work. 
Suggestion:

    background-color: #f7c590;

-------------

PR: https://git.openjdk.java.net/jdk/pull/4795


More information about the javadoc-dev mailing list