RFR: JDK-8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing

Jonathan Gibbons jjg at openjdk.java.net
Thu Jun 3 17:02:38 UTC 2021


On Tue, 1 Jun 2021 16:21:56 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Removal of ugly old code in `SerializedFormBuilder.java`. Luckily there already is a clean overloaded method in the associated writer that we can use, so this is mostly a removal of code that is no longer used.
> 
> I also enhanced the test to cover more cases such as primitive arrays and linked references.

Marked as reviewed by jjg (Reviewer).

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java line 123:

> 121:         } else {
> 122:             Content fieldContent = writer.getLink(new HtmlLinkInfo(
> 123:                     configuration, HtmlLinkInfo.Kind.SERIAL_MEMBER, fieldType));

Just curious, is SERIAL_MEMBER still required?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4284


More information about the javadoc-dev mailing list