RFR: JDK-8266748: Move modifiers code to Signatures.java [v2]

[Hannes Wallnöfer]

On Thu, 3 Jun 2021 17:22:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Minor changes suggestion, to access items from the configuration where possible.
> 
> As a followup, it would be good to look at the remaining uses of `HtmlDocletWriter` in `Signatures`. There is at least a theme of "methods to create links", and if those methods are just used in the `Signatures` class, they would be candidates to move into that class as well.

I changed the mentioned accesses to  use configuration instead of writer. 

Most of the link methods in `HtmlDocletWriter` are used all over the place. `addSrcLink` is only used in `TypeSignature` and `MemberSignature`, but there's various circumstances that makes a move to Signatures unattractive (it accesses fields in HtmlDocletWriter, to which static nested classes TypeSignature and MemberSignature don't share a common reference).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4142