RFR: JDK-8157682: @inheritDoc doesn't work with @exception

Jonathan Gibbons jjg at openjdk.java.net
Thu Mar 4 15:50:44 UTC 2021


On Thu, 4 Mar 2021 14:22:14 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> This commit changes the order of block tags in the output. The fact that no tests failed when I ran them surprised me. I think we should both fix that order and introduce a test for it.

Can you give more details?  Did you observe that anywhere, or are you inferring that from the code somewhere?

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java line 590:
> 
>> 588:                     if (!list.contains(t)) {
>> 589:                         list.add(t);
>> 590:                     }
> 
> I suppose the purpose of that is to filter out a now duplicated `ThrowsTaglet`. We should separately consider using a more appropriate data structure there.

yeah, but ... this is just one-off init ... it's the "standard" problem of list vs. sets, and list-y sets vs. set-y lists.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2818


More information about the javadoc-dev mailing list