RFR: JDK-8157682: @inheritDoc doesn't work with @exception [v4]

Pavel Rappo prappo at openjdk.java.net
Fri Mar 5 10:23:41 UTC 2021


On Thu, 4 Mar 2021 23:01:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a fix to improve the handling of the legacy `@exception` tag.
>> 
>> A patch for this was [previously submitted](https://mail.openjdk.java.net/pipermail/javadoc-dev/2019-September/001139.html). However, that patch introduced an explicit new `ExceptionTaglet` class, whereas the fix here just reuses the existing `ThrowsTaglet`, registering it under an additional name.
>> 
>> The test in the original patch is enhanced to check all 4 combinations of (throws, exception) in the base class and (throws, exception) in the subclass.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update comment for allTaglets

I can see that you propose to add a test for the output order of block tags separately: https://git.openjdk.java.net/jdk/pull/2835 (JDK-8263043).

Looks good.

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2818


More information about the javadoc-dev mailing list