RFR: JDK-8260388: Listing (sub)packages at package level of API documentation [v2]

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Mar 24 16:35:31 UTC 2021


I like it except that I was expecting the module name (column) to 
precede the package name (column).

Is there a strong reason to have the module name column appear second?

-- Jon

On 3/24/21 8:04 AM, Hannes Wallnöfer wrote:
> On Fri, 12 Mar 2021 17:37:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>
>>> Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>>
>>>   - JDK-8260388: Show module column in related packages table if packages are in different modules
>>>   - Merge branch 'master' into JDK-8260388
>>>   - JDK-8260388: Listing (sub)packages at package level of API documentation
>> All OK; some suggestions for future work/cleanup/improvement
> I have added a change to this PR to add a "Module" column to the related packages table if any of the packages is in a different module. Example output for the JDK libraries is available here (`java.lang`, `java.util` and `com.sun.tools.*` packages have a module column):
>
> http://cr.openjdk.java.net/~hannesw/8260388/api.03/
>
> Implementation note: I added a HtmlStyle.colExtra CSS style because existing column classes either had unwanted rules (such as displaying links in bold font) or didn't fit for other reasons.
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/2917


More information about the javadoc-dev mailing list