RFR: JDK-8260388: Listing (sub)packages at package level of API documentation [v3]

Hannes Wallnöfer hannesw at openjdk.java.net
Thu Mar 25 08:41:05 UTC 2021


On Thu, 25 Mar 2021 00:59:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8260388: Add check for configuration.showModules
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java line 169:
> 
>> 167:         boolean showModules = configuration.showModules && hasRelatedPackagesInOtherModules(relatedPackages);
>> 168:         TableHeader tableHeader= showModules
>> 169:                 ? new TableHeader(contents.packageLabel, contents.moduleLabel, contents.descriptionLabel)
> 
> This is OK, but I think it would be better if the module column came first.

I tried it out and was very surprised to find I agree with you. I'm changing the order in a new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2917


More information about the javadoc-dev mailing list