RFR: JDK-8263684: Avoid wrapping into BufferedWriter twice

[Pavel Rappo]

On Tue, 18 May 2021 04:33:52 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to avoid creating an unnecessary `BufferedWriter`.
> 
> `noreg-trivial` (or `noreg-cleanup` : take your pick). Either way, no test.

Changes requested by prappo (Reviewer).

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ElementListWriter.java line 79:

> 77:         try (Writer fileWriter = file.openWriter();
> 78:              BufferedWriter out = (fileWriter instanceof BufferedWriter b) ? b
> 79:                      : new BufferedWriter(file.openWriter())) {

Don't call `file.openWriter()` second time, reuse `fileWriter` that you already have.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4080