RFR: JDK-8267219: Javadoc method summary breaks when {@inheritDoc} from an empty parent [v3]

[Pavel Rappo]

On Tue, 18 May 2021 15:36:26 GMT, liach <github.com+7806504+liach at openjdk.org> wrote:

>> This change fixes when a method body has only inline tags that produce no output, the method summary will get eaten.
>> 
>> This change allows `{@inheritDoc}` from empty parents to go through the code path used by `-nocomment` and properly generate tables.
>> 
>> All `jtreg:test/langtools/jdk/javadoc/doclet` tests pass.
>
> liach has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Changes requested by prappo (Reviewer).

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/ContentBuilder.java line 99:

> 97:         for (Content content: contents) {
> 98:             if (content.isValid())
> 99:                 return true;

If this is correct, then it deserves a comment. The reason is that it looks counterintuitive: I would expect isValid to have the semantics of &&, not ||.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4066