Integrated: JDK-8266651: Convert Table method parameters from String to Content

Hannes Wallnöfer hannesw at openjdk.java.net
Wed May 19 13:04:40 UTC 2021


On Wed, 12 May 2021 12:43:48 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> This changes the parameter type for the tab label from `String` to `Content` in the `formats.html.Table` `addTab` and `setDefaultTab` methods. The change is straightforward because the tab name was converted to `Content` anyway, and all resources are readily available in `Content` form. 
> 
> I briefly considered overriding the `hashCode` and `equals` methods in `Text` to be depend on content instead of object identity, but decided against it. This would just cover up bugs where we generate the same content twice. (In the process I made sure we currently don't have any such cases where a `Text` instance is compared to another one with the same string content.)

This pull request has now been integrated.

Changeset: 12050f04
Author:    Hannes Wallnöfer <hannesw at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/12050f04ca1a170d9dece1fd902dc8306c746eb8
Stats:     60 lines in 8 files changed: 1 ins; 3 del; 56 mod

8266651: Convert Table method parameters from String to Content

Reviewed-by: jjg

-------------

PR: https://git.openjdk.java.net/jdk/pull/3994


More information about the javadoc-dev mailing list