Integrated: JDK-8276768: Snippet copy feature should use button instead of link

Hannes Wallnöfer hannesw at openjdk.java.net
Mon Nov 8 11:38:40 UTC 2021


On Fri, 5 Nov 2021 19:58:03 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> This change reimplements the snippet copy-to-clipboard feature using a single `<button>` element instead of a `<a href="#">` with an attached `::before` pseudo-element.
> 
> While the implementation is more straightforward than before both appearance and functionality should be unchanged. The only (intentional) change is that the new button has a bit more clickable area (i.e. padding) than the old link, but this is offset by the button's positioning so the location of the image and text does not change.
> 
> A sample page rendered with the new code containing a few snippets is available here:
> http://cr.openjdk.java.net/~hannesw/8276768/api.00/Test.html

This pull request has now been integrated.

Changeset: 0395e4ef
Author:    Hannes Wallnöfer <hannesw at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/0395e4ef8ced8385cc2c9b3bea4c6f4490c62d2b
Stats:     86 lines in 5 files changed: 16 ins; 16 del; 54 mod

8276768: Snippet copy feature should use button instead of link

Reviewed-by: prappo

-------------

PR: https://git.openjdk.java.net/jdk/pull/6284


More information about the javadoc-dev mailing list