RFR: 8273544: Increase test coverage for snippets [v2]

[Pavel Rappo]

On Thu, 18 Nov 2021 11:41:27 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java line 71:
>> 
>>> 69:  *    3. ("Inline", "External", "Hybrid")
>>> 70:  *    4. ("Tag", "Markup")
>>> 71:  *    5. <custom string>
>> 
>> I assume the purpose of this naming scheme is to make visible what combinations of features are covered by each test. I'm not sure I would consider this enough benefit to justify method names which are very verbose and hard to read (especially when you don't have fresh memory of the scheme above).
>
> When one is planning to have many methods, one should better have a plan for how to maintain them. Such a plan should cover navigation, search, and if growth is foreseen, naming new methods. A naming scheme could in itself be such a plan.
> 
> I've tried alternative naming schemes but found this one to work best. It's obviously possible that I missed something. If you have other ideas, please share and let's discuss them.

> I assume the purpose of this naming scheme is to make visible what combinations of features are covered by each test. I'm not sure I would consider this enough benefit to justify method names which are very verbose and hard to read (especially when you don't have fresh memory of the scheme above).

You are right when saying that this naming scheme helps to survey the test landscape. This is especially helpful while mass-developing tests, which is what I'm doing at the moment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6359