RFR: 8273544: Increase test coverage for snippets [v2]

[Jonathan Gibbons]

On Fri, 19 Nov 2021 16:40:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> OK, but the test purist in me dislikes the significant amount of inline overhead to address this concern.
>> 
>> I'll pass on this for now, because I agree with unblocking the dependent PRs, but it seems like that is a negative side-effect of dependent PRs in general.  Once we get past this, at a minimum, I would suggest moving the in-memory file manager out of this class, and then potentially reconsider the decision that it is good practice to do the separate run.
>
>> As for text blocks: to me, indenting a text block is a complex, subjective and unsettled issue. I would postpone re-indenting them for now, primarily because of the churn it would otherwise introduce to the dependent PRs.
> 
> _complex, subjective and unsettled_?  Really? JEP 378 would indicate otherwise!   So, I disagree with the lack of indent, but (reluctantly) agree on the churn causing issues for dependent t PRs.

(Cleanup suggestion, for later?)  maybe embed the `{@link}` in a separate comment, maybe even in a separate class or file, but still processed in the same run of `javadoc`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6359