RFR: 8276124: Provide snippet support for properties files [v5]

Pavel Rappo prappo at openjdk.java.net
Wed Nov 24 16:11:41 UTC 2021


On Wed, 24 Nov 2021 15:52:15 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Use Hannes' regex
>>    
>>    Shortens regexes and makes them use fewer concepts (no lookahead).
>>  - Implement Jon's suggestion (3)
>>    
>>    Cleans up.
>>  - Implement Jon's suggestion (2)
>>    
>>    Substitutes regex for CoarseParser and its implementations.
>>  - Implement Jon's suggestion (1)
>>    
>>    Uses named groups and positive lookahead to make both regexes uniform in respect to accessing the components of a match.
>
> test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetMarkup.java line 373:
> 
>> 371:     }
>> 372: 
>> 373:     // @replace on a blank line will not do anything bad!
> 
> What is the purpose of this comment? Is this used as snippet source somewhere?

This is an artifact of me thinking of three interdependent PRs simultaneously. A marginal note, if you will. This line should be translated into a new test in the upcoming PR, #6461. I'll move it there, thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6397


More information about the javadoc-dev mailing list