RFR: JDK-8269401: Merge "Exceptions" and "Errors" into "Exception Classes" [v2]
Hannes Wallnöfer
hannesw at openjdk.java.net
Thu Oct 21 13:10:11 UTC 2021
On Thu, 21 Oct 2021 11:09:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8269401: Include Throwable in exception classes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SummaryListWriter.java line 66:
>
>> 64: case ENUM -> "doclet.Enums";
>> 65: case EXCEPTION_CLASS -> "doclet.ExceptionClasses";
>> 66: case ANNOTATION_TYPE -> "doclet.Annotation_Types";
>
> (Possibly unrelated to this PR.) This kind of inconsistency in naming is surprising. Even more surprising is the fact that these two resources live in different files. While `ExceptionClasses` lives in doclet.properties, `Annotation_Types` lives in standard.properties. To confuse things even further, `AnnotationType` and `ExceptionClass` live in the same file, doclet.properties.
Interesting: We have property `doclet.Annotation_Types` (with underscore) defined in `standard.properties` and `doclet.AnnotationTypes` (without underscore) in `doclets.properties. Both properties have the same value. Smells like another cleanup task.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6061
More information about the javadoc-dev
mailing list