RFR: JDK-8274172: Convert JavadocTester to use NIO [v2]

[Jonathan Gibbons]

On Fri, 24 Sep 2021 12:45:51 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments;
>>   Move `JavadocTester.copyDir` to `ToolBox`; use FileVisitor code
>
> test/langtools/tools/lib/toolbox/ToolBox.java line 270:
> 
>> 268:     public void copyDir(Path fromDir, Path toDir) {
>> 269:         try {
>> 270:             Files.createDirectories(toDir);
> 
> Do not create this directory manually. It will be created first thing in your visitor.
> Suggestion:

The suggestion is incorrect.  The call is required to ensure that parent directories of `toDir` are created.   These are __not__ created by the call in the visitor.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5644