RFR: JDK-8274172: Convert JavadocTester to use NIO [v3]

[Pavel Rappo]

On Fri, 24 Sep 2021 17:00:14 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a moderately simple update to convert JavadocTester to just use NIO, instead of a mix of File and NIO.
>> 
>> The original code used java.io.File. At some point (JDK 9-ish) new code was added that used NIO, resulting in a mix. This change converts the old code to use NIO as well.
>> 
>> This is mostly internal, with two changes that affect tests.
>> 
>> 1. The `protected` field `outputDir` is changed from a `File` to a `Path`.   Some tests use `outputDir` directly, typically to convert it to a `Path`.
>> 2. The `copyDir` method had a strange spec.  Partly, it used "target" to describe the directory being copied, but worse, it copied the entire source directory INTO the destination directory, as compared to copying the contents.  The method was just used in a single test, so I've changed the spec of the method and the use in the test.  This cleaned up a "TODO" as well, to use `Files.walkFileTree` for the copy.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Simplify ToolBox.copyDir
>    Revert bad IDE suggestion
>  - Merge with upstream/master
>  - Address review comments;
>    Move `JavadocTester.copyDir` to `ToolBox`; use FileVisitor code
>  - JDK-8274172: Convert JavadocTester to use NIO

Reviewed on the condition that you won't push it with

    Files.createDirectories(toDir.toAbsolutePath().getParent())

as you suggested earlier.

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5644