RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken [v4]

Hannes Wallnöfer hannesw at openjdk.java.net
Thu Sep 30 10:48:36 UTC 2021


On Tue, 28 Sep 2021 08:23:30 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Could you please review the 8248001 bug fixes?
>> 
>> The problem is that javadoc generates invalid HTML pages whose ftp:// links are broken. The fix changes not to use protocol names directly, but to use regular expression.
>
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Changes requested by hannesw (Reviewer).

test/langtools/jdk/javadoc/doclet/testHrefInDocComment/pkg/J1.java line 27:

> 25: 
> 26: /**
> 27:  *This class has <a href="{@docRoot}/pkg/J1.html#functions">various functions</

Unclosed `a` element

test/langtools/jdk/javadoc/doclet/testHrefInDocComment/pkg/J1.java line 50:

> 48: 
> 49:     /**
> 50:      *<a href="{@docRoot}/pkg/J1.html#functions">Creates an instance which has

Another unclosed `a` element

-------------

PR: https://git.openjdk.java.net/jdk/pull/5198


More information about the javadoc-dev mailing list