RFR: JDK-8236048: Cleanup use of Utils.normalizeNewlines [v2]
Hannes Wallnöfer
hannesw at openjdk.org
Thu Aug 18 16:19:22 UTC 2022
On Tue, 16 Aug 2022 21:35:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/RawHtml.java line 161:
>>
>>> 159: }
>>> 160: count++;
>>> 161: break;
>>
>> The RawHtml constructor contains `assert Text.checkNewlines(rawHtml)` so I'm not sure this is actually needed.
>
> I'm not sure what you are referring to here. Yes, there is the assertion about newlines, but you still have to scan the `rawHtml` for start and end elements, and entities. Note there is no longer any special handling of newline characters (`\r`, `\n` etc)
Sorry, I somehow misread the diff.
-------------
PR: https://git.openjdk.org/jdk/pull/9691
More information about the javadoc-dev
mailing list