RFR: 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring [v3]

[Pavel Rappo]

On Fri, 25 Feb 2022 18:30:47 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix outdated code
>>    
>>    Uses a set instead of list for quick method search. In a future commit we'll try to figure out why `found` are not unique.
>>  - Fix outdated code
>>    
>>    Fix outdated inline comments and names. Both the assertion and the `contains` method will be removed in a future commit.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java line 3087:
> 
>> 3085:              !previewAPIs.reflectivePreviewAPI.isEmpty() ||
>> 3086:              !previewAPIs.declaredUsingPreviewFeature.isEmpty()) &&
>> 3087:             !hasNoPreviewAnnotation(el)) {
> 
> I know this fix is just a typo fix, but that aside, the if-expression would be improved with more indentation to help show the binding of the parens, `||` and `&&`. A default indentation of 1 character is too small in this case, IMO.

Don't bother: a subsequent merge with the mainline (see JDK-8277300) made that particular change irrelevant and fixed that indentation in one go.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7233