RFR: 8280713: Related to comment inheritance jdk.javadoc cleanup and refactoring [v3]

Jonathan Gibbons jjg at openjdk.java.net
Fri Feb 25 20:19:50 UTC 2022


On Fri, 25 Feb 2022 17:46:05 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Explorative refactoring performed while looking into multiple `@inheritDoc` issues. The easiest way to review it is to, probably, go commit by commit; they are quite focused and commented. Not only the branch as a whole, but all the constituent commits should pass tests and leave JDK API Documentation unchanged.
>
> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix outdated code
>    
>    Uses a set instead of list for quick method search. In a future commit we'll try to figure out why `found` are not unique.
>  - Fix outdated code
>    
>    Fix outdated inline comments and names. Both the assertion and the `contains` method will be removed in a future commit.

Commit: Simplify VisibleMemberTable.ImplementedMethods

OK

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java line 1012:

> 1010:             for (TypeMirror interfaceType : intfacs) {
> 1011:                 // TODO: this method also finds static methods which are pseudo-inherited;
> 1012:                 //  this needs to be fixed

yeah, there's (at least) two concepts here: visible members (note the name of the class!) and the implemented members.   Note that the `@see`/`@link` syntax doesn't distinguish static or not, it just wants "visible".

-------------

PR: https://git.openjdk.java.net/jdk/pull/7233


More information about the javadoc-dev mailing list