RFR: JDK-8268831: Improve javadoc tool handling of streams.

[Hannes Wallnöfer]

On Tue, 4 Jan 2022 01:17:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a relatively simple cleanup left over from last year's cleanup for `JavadocLog` (was `Messager`).
> 
> The cleanup here is to rationalize the inconsistent naming and use of methods named `notice` in `JavadocLog` and `ToolEnvironment`, as well as cleanup use of the primitive `Log.printRawLines`. While it would have been nice to move the definition of `ToolEnvironment.notice` into `JavadocLog`  that dragged with it the need for the `quiet` variable, which led to initialization order problems.  The proposed solution is a compromise.
> 
> No tests are affected; `noreg-cleanup`.

Looks good to me. 

Am I right in the assumption that the writer for `WriterKind.NOTICE` in javadoc is always stdout? I couldn't figure out where the writers are set (I guess it is somewhere in jdk.compiler code).

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6950