Integrated: JDK-8268831: Improve javadoc tool handling of streams.
Jonathan Gibbons
jjg at openjdk.java.net
Wed Jan 19 17:59:29 UTC 2022
On Tue, 4 Jan 2022 01:17:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review a relatively simple cleanup left over from last year's cleanup for `JavadocLog` (was `Messager`).
>
> The cleanup here is to rationalize the inconsistent naming and use of methods named `notice` in `JavadocLog` and `ToolEnvironment`, as well as cleanup use of the primitive `Log.printRawLines`. While it would have been nice to move the definition of `ToolEnvironment.notice` into `JavadocLog` that dragged with it the need for the `quiet` variable, which led to initialization order problems. The proposed solution is a compromise.
>
> No tests are affected; `noreg-cleanup`.
This pull request has now been integrated.
Changeset: 610a1290
Author: Jonathan Gibbons <jjg at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/610a12904d834507754e6d6171a4b8df7e6aa6b0
Stats: 69 lines in 5 files changed: 15 ins; 25 del; 29 mod
8268831: Improve javadoc tool handling of streams.
Reviewed-by: hannesw
-------------
PR: https://git.openjdk.java.net/jdk/pull/6950
More information about the javadoc-dev
mailing list