RFR: JDK-8272984: javadoc support for reproducible builds [v4]
Hannes Wallnöfer
hannesw at openjdk.java.net
Wed Jan 26 11:34:31 UTC 2022
On Tue, 25 Jan 2022 19:43:08 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Please review a javadoc update to support a new `--date` option to support reproducible builds.
>>
>> This pull request supersedes https://github.com/openjdk/jdk/pull/6905. In that PR, the `SOURCE_DATE_EPOCH` environment variable was used to provide the time stamp, but review feedback suggested the use of a new command-line option, `--date`. The format of the argument of the `--date` option is that same as that of similar options for the _jar_ and _jmod_ tools, and the code to handle the value is based on code in the _jar_ tool.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review feedback: propagate time zone
Looks good to me.
The CSR should be updated to reflect the changed option help message. Talking about that change: I'm a bit unsure about it, as ISO 8601 does not include the optional zone ID, which is an extension in `DateTimeFormatter.ISO_ZONED_DATE_TIME`. So maybe the previous message was more correct and useful after all?
-------------
Marked as reviewed by hannesw (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7171
More information about the javadoc-dev
mailing list