RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v3]
Jonathan Gibbons
jjg at openjdk.java.net
Mon Jun 6 21:32:17 UTC 2022
On Fri, 3 Jun 2022 14:47:13 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only copies one instance of the specified exception.
>
> Pavel Rappo has updated the pull request incrementally with three additional commits since the last revision:
>
> - Remove upper-bounded wildcard
>
> This change simplifies code without any disadvantages:
>
> * Those `List<? extends XTree>` are read-only
> * An argument of the `List<XTree>` type can still be passed to a `List<? extends XTree>` parameter
> - Simplify inheritThrowsDocumentation
> - Reuse more specific variable
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java line 92:
> 90: ? utils.getTypeParamTrees(ee)
> 91: : utils.getParamTrees(ee);
> 92: List<? extends Element> parameters = input.isTypeVariableParamTag
Change both or neither; don't leave the code inconsistent
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java line 164:
> 162: ParamKind kind,
> 163: List<ParamTree> tags,
> 164: List<? extends Element> parameters,
visually inconsistent
-------------
PR: https://git.openjdk.java.net/jdk/pull/8886
More information about the javadoc-dev
mailing list