RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v4]

Jonathan Gibbons jjg at openjdk.java.net
Tue Jun 7 05:55:11 UTC 2022


On Tue, 7 Jun 2022 00:26:13 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java line 237:
>> 
>>> 235:         Utils utils = writer.configuration().utils;
>>> 236:         Content result = writer.getOutputInstance();
>>> 237:         for (TypeMirror declaredExceptionType : declaredExceptionTypes) {
>> 
>> Two comments may have been too many, but zero is too few.
>
> Did you see the name of that private method? Looks pretty self-descriptive to me. I'm not sure why you think it needs any comment, but I can re-introduce it, if you wish so.

Yeah, the name is not great, and that shows up when you see the 3 groups of exceptions side by side lower down.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8886


More information about the javadoc-dev mailing list