RFR: 8287333: Clean up ParamTaglet and ThrowsTaglet [v6]
Pavel Rappo
prappo at openjdk.java.net
Wed Jun 8 17:01:48 UTC 2022
On Tue, 7 Jun 2022 20:36:26 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> A cleanup to facilitate fixing bugs like JDK-6509045: `{@inheritDoc}` only copies one instance of the specified exception.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 37 commits:
>
> - Merge branch 'master' into 8287333
> - Address feedback
>
> Replaces String with Integer in position map. In contrast with ThrowsTaglet, using String instead of a more suitable type for Input.tagId is not a lossy transformation. So it can still be considered as cleanup. But generally it should be dealt with in 8285488.
> - Merge branch 'master' into 8287333
>
> It's two days before RDP1, the codebase changes quickly. This merge is to keep up with it.
> - Address feedback
>
> Also removes unneeded import.
> - Merge branch 'master' into 8287333
>
> This resolves a conflict in ParamTaglet.
> - Clean up if-branch
> - Remove upper-bounded wildcard
>
> This change simplifies code without any disadvantages:
>
> * Those `List<? extends XTree>` are read-only
> * An argument of the `List<XTree>` type can still be passed to a `List<? extends XTree>` parameter
> - Simplify inheritThrowsDocumentation
> - Reuse more specific variable
> - Merge branch 'master' into 8287333
> - ... and 27 more: https://git.openjdk.java.net/jdk/compare/1aa87e00...418d07b5
In a mature system such as jdk.javadoc, a cleanup is a careful and continuous process. I'll integrate what has been approved and continue cleanup in JDK 20.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8886
More information about the javadoc-dev
mailing list